Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualization specification: Is tsv the right choice? #499

Open
dweindl opened this issue Jan 18, 2021 · 2 comments
Open

Visualization specification: Is tsv the right choice? #499

dweindl opened this issue Jan 18, 2021 · 2 comments
Labels

Comments

@dweindl
Copy link
Member

dweindl commented Jan 18, 2021

Regarding the visualization specification in PEtab1.0:
I was wondering whether the tsv format was really a good choice there. Currently each line in the visualization table corresponds to one data series. The lines are grouped into plots based on plotId. For each data series one can set plot-level properties such as axis labels, axis scaling, etc. This makes it unnecessarily complex, as only one of those values can actually be used. Maybe this would be better done in YAML in a future version, which would be more able to account for a hierarchical specification of plotting properties? Any opinions?

@dweindl dweindl added question Further information is requested visualization specification change labels Jan 18, 2021
@yannikschaelte
Copy link
Member

I would agree that yaml may help avoid the redundancy/complexity. What is your opinion experts @plakrisenko @erikadudki @MerktSimon ?

@MerktSimon
Copy link
Member

MerktSimon commented Jan 18, 2021

I would say, it is not really more complex to rewrite the plot level specifications for each line of a plotId. But it is definitely redundant.
Plus for tsv is imO that everyone can easily alter it with any office software without knowledge of syntax.
On the other hand yaml could allow for even more optional plot level specifications, maybe even general matplotlib kwargs, and hence more detailed reproducibility. (or figure level specifications cf #498)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants