Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Generalized calendar fixes #1058

Open
acordonez opened this issue Feb 20, 2024 · 0 comments
Open

[Feature]: Generalized calendar fixes #1058

acordonez opened this issue Feb 20, 2024 · 0 comments

Comments

@acordonez
Copy link
Collaborator

acordonez commented Feb 20, 2024

Is your feature request related to a problem?

With xcdat, we cannot open datasets and decode times if the dataset uses a non cf-compliant calendar.

Describe the solution you'd like

We can add functionality to either edit calendar types to be cf-compliant if possible. I have an example of changing the calendar name here: https://github.com/acordonez/pcmdi_metrics/blob/variability_fixes/pcmdi_metrics/precip_variability/lib/lib_variability_across_timescales.py#L32-L40. In this example, I've added a fix to convert calendar names with hyphens to use underscores.

Describe alternatives you've considered

We could only allow PMP to work with cf-compliant calendars, but that would be very restrictive.

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant