Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML Imports is deprecated error still here! #228

Closed
markddesimone opened this issue Oct 8, 2020 · 5 comments
Closed

HTML Imports is deprecated error still here! #228

markddesimone opened this issue Oct 8, 2020 · 5 comments

Comments

@markddesimone
Copy link

markddesimone commented Oct 8, 2020

image

I was getting this error so I checked the sample: https://colab.research.google.com/github/PAIR-code/facets/blob/master/colab_facets.ipynb. it is still getting the error.

I am on linux Ubuntu 18.04.5 LTS, Chrome Version 85.0.4183.121 (Official Build) (64-bit)

The script is using:

<script src="https://cdnjs.cloudflare.com/ajax/libs/webcomponentsjs/1.3.3/webcomponents-lite.js"></script>

as recommended as the solution in #206 and #211

@jameswex
Copy link
Collaborator

jameswex commented Oct 9, 2020

Thanks for reaching out. That warning in the console is now expected, as Facets uses HTML imports, but through the webcomponents polyfill script, which is necessary since native suppoort was removed in Chrome M80.

Assuming the Facets visualizations are working as expected, the warning should be ignored.

@jameswex jameswex closed this as completed Oct 9, 2020
@markddesimone
Copy link
Author

markddesimone commented Oct 9, 2020

@jameswex, thank you. It works when the cell is first executed but if I re-run the cell I have the issues described in #227. I had been wondering if this was the cause. I have to totally restart jupyter to get my cell to render properly again, just shutting down the kernel for my notebook does not resolve it...

@mugglmenzel
Copy link

The issue still is present in Jupyter notebooks. Facets is not usable anymore on any Google Cloud notebook (CAIP, Vertex AI).

@jameswex
Copy link
Collaborator

jameswex commented Jul 8, 2021

@mugglmenzel As a test I just created a new virtualenv, did "pip install jupyter facets-overview protobuf", then ran "jupyter notebook" and ran the "Facets Dive and Overview Colab Example" notebook (skipping the first cell as that is only for when running in colab). I was able to see the Facets visualization, even though the HTML imports warning is shown (as expected).

Are you able to use it in plain Jupyter notebooks? I'm wondering if the issue is with a specific notebook environment and not all jupyter notebooks.

@shawngiese
Copy link

I just tried it too... new virtualenv, did "pip install jupyter facets-overview protobuf", and ran "jupyter notebook". Then my own data loaded fine. I still get the same "HTML Imports is deprecated" warning but the facets overview loads fine (1.7 million rows). In my non-virtualenv with lots of libraries, the facets-overview never loads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants