Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird effects after setting filteredDataIndices #210

Open
rmcloughlin opened this issue Mar 9, 2020 · 2 comments
Open

Weird effects after setting filteredDataIndices #210

rmcloughlin opened this issue Mar 9, 2020 · 2 comments
Assignees

Comments

@rmcloughlin
Copy link

Settings the filteredDataIndices property on a <facets-dive> component causes some weird things to happen in the UI.

  1. There sometimes seem to be two copies of the moving yellow selection rectangle.

Screen Shot 2020-03-09 at 12 06 24 PM

  1. You can select data points that aren't visualized.

Screen Shot 2020-03-09 at 12 06 46 PM

To reproduce, go to https://pair-code.github.io/facets/quickdraw.html, then in the chrome devtools console, run

const fdComponent = document.querySelector('facets-dive');
fdComponent.filteredDataIndices = [0,1,2,3,4,5];
// then click somewhere not on the six faces
// then click on one of the six faces
@rmcloughlin
Copy link
Author

This is on Google Chrome 80.0.3987.132 on Mac OS 10.15.3

@jameswex
Copy link
Collaborator

jameswex commented Mar 9, 2020

Thanks for the report. I'm able to repro the issue and see that selecting items outside of this displayed is possible, and causes fdComponent.selectedIndices to show items selected that shouldn't be visible, and selecting the top-right element in your case causes selectedIndices to contain the correct datapoint index, and also a second index for an item that shouldn't be visible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants