Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ExoPlayer for duration parsing #661

Open
4 tasks done
nemesis-vampy opened this issue Jan 5, 2024 · 3 comments
Open
4 tasks done

Use ExoPlayer for duration parsing #661

nemesis-vampy opened this issue Jan 5, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request music Related to music loading

Comments

@nemesis-vampy
Copy link

Describe the Bug/Crash

some songs in my library show a duration of --:--, and the albums they are in show a duration of 0:00:
image

Describe the intended behavior

should display the true duration of the songs and their albums.
vlc, for example, correctly displays the duration:
image

What android version do you use?

Android 14

What device model do you use?

samsung galaxy s22

Bug report

n/a?

Duplicates

@nemesis-vampy nemesis-vampy added the bug Something isn't working label Jan 5, 2024
@OxygenCobalt
Copy link
Owner

Can you provide sample files @nemesis-vampy? I cannot tell if this is a consequence of poor format support or your device's MediaStore database being broken (VLC uses it's own custom parser for durations, for now I still rely on MediaStore which is much flakier). Just make sure to strip the audio out if its copyrighted, I only need the tags anyway.

@OxygenCobalt OxygenCobalt changed the title some songs/albums show a duration of 0:00/--:-- Some songs/albums show a duration of 0:00 Jan 5, 2024
@OxygenCobalt OxygenCobalt added the music Related to music loading label Jan 5, 2024
@nemesis-vampy
Copy link
Author

of course.
examples.zip

@OxygenCobalt
Copy link
Owner

OxygenCobalt commented Jan 5, 2024

I can't seem to reproduce this. This implies this is largely device-specific. I'll convert this issue into a related enhancement about effectively using ExoPlayer for duration parsing as a fallback (Currently the maintainers don't support it, so it would have to be a manual patch).

@OxygenCobalt OxygenCobalt changed the title Some songs/albums show a duration of 0:00 Use ExoPlayer for duration parsing Jan 5, 2024
@OxygenCobalt OxygenCobalt added enhancement New feature or request and removed bug Something isn't working labels Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request music Related to music loading
Projects
Status: v4.X.0
Development

No branches or pull requests

2 participants