Would you welcome a PR to use FRONTEND_URL for providing dynamic docs when self hosting?

[tarasis]

Hi,

I'm running an instance of this on my local server, so I'm not constantly hitting the official API as I'm playing around and learning.

I've tweaked the project to use the FRONTEND_URL environment variable, so that the docs are updated to reflect that url using <%= process.env.FRONTEND_URL %> rather than dummyjson.com (except for the CDN requests for the images as they aren't part of the repo).

Is it possible for you to put the images in the project repo so they could be served locally? Rather than hitting your CDN?

Lastly, thanks for the API and project. Very useful.

[Ovi]

Good point @tarasis, I will work on it

[tarasis]

Excellent! Its something I've basically done, but if you wish to do it yourself I totally understand (just remember you have both www.dummyson.com, dummyjson.com and cdn.dummyjson.com in the docs ... only the first two need to be dealt with till the images are in the repo)

<3

[Ovi]

If that's something you can share, I'd love to see a PR.

[tarasis]

Will get it to you tomorrow. Late here. Even if you don't use it, it might give you guidance.

The main issue I had was playing with use of '' & "", or specificially embedded ' "" ' ... ideally <%= process.env.FRONTEND_URL %> should be quoted out so it doesn't cause havoc BUT if you do it breaks the transform process and so nothing happens when the code is processed. So <%= process.env.FRONTEND_URL %> needs to go in raw, and as it only happens in the compile process thats fine. In theory its only "us" doing that (esp if its behind ssh / deploy process), so should be safe