Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing updates and code inconsistence #280

Open
Flixkowsky opened this issue Apr 8, 2022 · 1 comment
Open

Missing updates and code inconsistence #280

Flixkowsky opened this issue Apr 8, 2022 · 1 comment

Comments

@Flixkowsky
Copy link

Flixkowsky commented Apr 8, 2022

Awesome tutorial, really appreciating it 馃憤 but:

The example code provided in this repo does not match the little excerpts/code blocks inside the website.
Also the code blocks are not the same in the different language versions of the website.
#279

Example:
(links down below)
See the second code block in the given chapter

french website:
submitInfo.pCommandBuffers = &commandBuffers[imageIndex];
englisch website:
submitInfo.pCommandBuffers = commandBuffer;
github code 15_hello_triangle.cpp::L653:
submitInfo.pCommandBuffers = &commandBuffer;

@Krenodeno
Copy link
Contributor

Hi,
The tutorial was recently updated with a big change in how we record and use command buffers, the french translation is not up to date yet.
I'm trying to keep track of all the changes, but I'm lacking time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants