Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folder bookmark can be added as Home Page #1627

Open
fnkkio opened this issue Nov 30, 2019 · 9 comments · May be fixed by #1628
Open

Folder bookmark can be added as Home Page #1627

fnkkio opened this issue Nov 30, 2019 · 9 comments · May be fixed by #1628

Comments

@fnkkio
Copy link
Contributor

fnkkio commented Nov 30, 2019

Steps to reproduce:

  1. Go to Tools > Preferences > General
  2. Under Home Page select Use Bookmark
  3. Select This Folder to set a bookmark folder as Home Page

Actual:
Bookmark selection menu allows selection of folders.

Expected:
In this case, bookmark selection menu should not allows selection of folders; it doesn't make sense to have a bookmark folder as home page.

Video demo:
https://youtu.be/pc4Unu7_uvk

@fnkkio fnkkio changed the title Disable folder bookmark as Home Page Folder bookmark can be added as Home Page Dec 1, 2019
@Emdek
Copy link
Member

Emdek commented Dec 3, 2019

@fnkkio, I'm wondering if this is an issue in the first place, as long as it works properly and opens all links from the folder...
If it works "properly" then perhaps warning could be sufficient.

@Frenzie
Copy link
Member

Frenzie commented Dec 3, 2019

I agree, it's only an issue of sorts if nothing happens.

@fnkkio
Copy link
Contributor Author

fnkkio commented Dec 4, 2019

@Emdek @Frenzie
It does not open all webpages, it opens a webpage with the url: bookmarks:x (where x can be 0 / 1 / ...).
I should have been more specific in the description.

Also, in my opinion, even if it opened all webpages in the folder, it wouldn't make much sense since we have session for that.

@Frenzie
Copy link
Member

Frenzie commented Dec 4, 2019

But what does that webpage show? Does it display the folder?

@fnkkio
Copy link
Contributor Author

fnkkio commented Dec 4, 2019

@Frenzie It does not display anything.

@fnkkio
Copy link
Contributor Author

fnkkio commented Dec 4, 2019

Added video demo in first comment.

@Frenzie
Copy link
Member

Frenzie commented Dec 4, 2019

In the meantime I've reached a computer. ;-)

I think the correct behavior would be something more like this (as a separate tab):

Screenshot_2019-12-04_21-31-41

Or perhaps rather like this:

Screenshot_2019-12-04_21-32-20

Disallowing folder selection is of course an easy way out.

@fnkkio
Copy link
Contributor Author

fnkkio commented Dec 5, 2019

@Emdek @Frenzie

Verified this issue again: This only happens when the bookmark folder is no longer available; if the bookmark is available, it will ask to open all bookmark URLs in folder.
(As a side-note this happened to me because I was importing bookmark and because of an issue, bookmarks were not stored between application restarts).

If this is ok / the expected behaviour, then we can close this issue.

@Frenzie
Copy link
Member

Frenzie commented Dec 5, 2019

I'd say it should display a little error message about folder not found then. Sounds like the functionality is good. ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants