Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove forced restart if app wasn't started through Steam #29

Closed
wants to merge 1 commit into from
Closed

Remove forced restart if app wasn't started through Steam #29

wants to merge 1 commit into from

Conversation

alutman
Copy link

@alutman alutman commented Sep 14, 2018

The SteamManager class forces the application to shut down if it wasn't started through Steam. This blocks all attempts at running TurnSignal outside of Steam so the hours in it aren't tracked (#27).

This request simply removes calls to Application.Quit() and SteamAPI.RestartAppIfNecessary in SteamManager.cs

With this change, you can fix #27 by just running the exe directly.

Note: My Unity is bugged (haven't touched it for ages) so I couldn't test a build but it compiles fine in the Mono editor.

@benotter
Copy link
Collaborator

Heya, thanks for the feedback!

Sorry for the delay, work and life have been keeping me pretty burnt out on my own projects,

But it hit me the other day, I missed the anniversary of my own app, my first public release.
That realization cut me a bit deeper than I would have thought.
I missed TurnSignal's birthday, people have begun asking if the project is dead, I've been neglectful of it.

Anyway, digressing, I'm making time now, and getting back to updates.

This is one of the most requested features, you've already done the research, and honestly, its such a small addition that would mean a lot to so many people, I've been kinda an asshole ignoring it so long, consider it done for the next update, which should hopefully be in less than a month.

@benotter
Copy link
Collaborator

Ack, just realized a mild problem, I can merge this with master, but master is only the currently released public version, in my lastest dev branch (2.4.5) I've completely removed Steamworks.net library in favor of the Facepunch.Steamworks one, but the core concept is the same.

I'll make the required changes in the newer code, and see about dropping you a credit in the update announce for doing the work for me in the first place, thanks for being awesome!

@benotter benotter closed this Sep 18, 2018
@benotter benotter added this to Potential Will-or-To Do in TurnSignal Improvement Project Sep 18, 2018
@benotter benotter moved this from Potential Will-or-To Do to Testing / Nearing Completion in TurnSignal Improvement Project Sep 18, 2018
@benotter benotter moved this from Testing / Nearing Completion to Archive in TurnSignal Improvement Project Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Unwanted time played
2 participants