Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stake button disabled with custom allowance #381

Open
micahalcorn opened this issue Mar 13, 2023 · 0 comments
Open

Stake button disabled with custom allowance #381

micahalcorn opened this issue Mar 13, 2023 · 0 comments
Assignees
@smitch88
Labels
bug Something isn't working P2 Small number of users are affected, major cosmetic issue ui/ux Workd that requires design and product overview

Comments

@micahalcorn
Copy link
Member

micahalcorn commented Mar 13, 2023 •
edited

Most users approve ERC-20 allowances with the "unlimited", proposed limit.

Screenshot 2023-03-12 at 6 32 16 PM

If a user sets a precise amount for the allowance and then tries to stake this amount in our app, the stake button will remain disabled, likely due to a rounding issue.

Example

  • I transferred 12,345.6789 OGV to 0x4797C31eE4743BFb8caa81D8605411fb1e402174.
  • Then I chose to stake "100%" of my holdings, which is rounded up in the UI to "12.35k".
  • After clicking "Approve Transfer", I clicked "Edit Permission", switched to "Custom spend limit", entered "12345.6789", and submitted the transaction.
  • My "Stake" button is still not enabled because the app thinks my approval is insufficient.

Screenshot 2023-03-12 at 6 37 15 PM

This issue was originally reported by 0x9154508c94a6D11A18a0c2a274B9bfC80243FD71.
@micahalcorn micahalcorn added bug Something isn't working help wanted Extra attention is needed ui/ux Workd that requires design and product overview P2 Small number of users are affected, major cosmetic issue labels Mar 13, 2023
@micahalcorn micahalcorn added this to the Sprint 47 milestone Mar 13, 2023
@micahalcorn micahalcorn removed the help wanted Extra attention is needed label Mar 15, 2023
@micahalcorn micahalcorn added the planned In-scope at the beginning of the sprint label Mar 24, 2023
@micahalcorn micahalcorn modified the milestones: Sprint 47, Sprint 48, Sprint 49 Apr 7, 2023
@micahalcorn micahalcorn modified the milestones: Sprint 49, Sprint 50 Apr 21, 2023
@micahalcorn micahalcorn removed the planned In-scope at the beginning of the sprint label Apr 21, 2023
@rafaelugolini rafaelugolini removed this from the Sprint 50 milestone Apr 21, 2023
@rolandpo rolandpo mentioned this issue Jul 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitch88 smitch88

Labels
bug Something isn't working P2 Small number of users are affected, major cosmetic issue ui/ux Workd that requires design and product overview
Projects
Origin DeFi (OUSD + OETH)
Status: To-do
Milestone
No milestone
Development

No branches or pull requests
3 participants
@micahalcorn @smitch88 @rafaelugolini