Don't collect rewards on stake

[micahalcorn]

Just tracking this as a possible feature request 📌 #253 (comment)

[micahalcorn]

Wow, I was just confused by this again in a matter of minutes. Here's my experience:

• I had 24.7k OGV in my wallet.
• I wanted to stake it all for a couple of months.
• I clicked "Create a new stake" and dragged the first slider (amount) all the way to the right.
• The text above said "25k" and I thought "fine, it's rounding up, but it's a little confusing".
• I submitted the transaction and then noticed that I had a remaining balance of 20.60 OGV.
• I thought that there must have been some slider issue and that it left me with some dust caused by rounding.
• Several minutes later, I realized that the 20.60 OGV was a result of collecting my Accrued Rewards upon staking.

This is not a good experience because (1) I never wanted the 24.7k OGV in the first place -- it was caused by inadvertently collecting rewards during a stake extension -- and (2) I was never told that my transaction would include collecting rewards when all I wanted to do was stake.

[tomhirst]

@micahalcorn A quick helper here would be to explain that all rewards are collected when creating a stake within the UI. I agree that it's really not great UX, though. Even if it was properly explained.

@DanielVF What's the reason to call _collectRewards() on stake?

ousd-governance/contracts/OgvStaking.sol

Line 143 in 36c9bc7

_collectRewards(to);