Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate ousd-analytics #311

Open
shahthepro opened this issue Apr 27, 2023 · 1 comment
Open

Deprecate ousd-analytics #311

shahthepro opened this issue Apr 27, 2023 · 1 comment

Comments

@shahthepro
Copy link
Collaborator

The team has mixed opinions about this, so creating this issue to consolidate all the thoughts I have about this and get some feedback/comments about this

Why we should deprecate this project:

  • Some of metrics and alerts overlap with the new Prometheus monitoring we have. It'd be easier and simpler to maintain one project rather than trying to maintain multiple projects that are supposed to do the same thing
  • Some in the team can work in Python but almost everyone seems to be more comfortable with JS. This has cost us some engineering time with context switching
  • We don't have any testing framework for this project despite every part of it being in-house. We have been following the "fix-forward" approach where we fix the bugs after it happens on production. This isn't ideal
  • The DB Schema (while it works) might not scale well, IMO. For instance, OusdTransfer model stores all transfer events of OUSD and we do a some aggregation on that model (to find the number of unique wallets holding it and stuff). As data in the model grows, this is gonna slow down all queries and we will have to come back to optimize it

Possible blockers for deprecating:

  • Prometheus monitoring doesn't do all of what this project does right now. We have to spend some time on getting that metric collection on par before we can deprecate
  • Decide on what we do with the data in DB
  • Figure out all services and frontends using the API exposed by this project and find an alternative way to do those

Potential options for blockers

  • @rafaelugolini suggested using Dune for all the data queries
  • For weekly and monthly reports, we could pull the data from Prometheus server (through a webhook or cron) and run it in a Lambda function
  • Spend more engineering time during the (rumoured?) tech-debt sprint to get Prometheus monitoring do all of what this project does and backfill all the data in the DB
@micahalcorn
Copy link
Member

micahalcorn commented Apr 27, 2023

Thanks for capturing this, @shahthepro. I too will believe tech debt sprint when I see it.

See also #305 for frontend concerns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants