Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzz to verify mint/redeem behavior without withdraw fee #1994

Closed
DanielVF opened this issue Mar 7, 2024 · 1 comment
Closed

Fuzz to verify mint/redeem behavior without withdraw fee #1994

DanielVF opened this issue Mar 7, 2024 · 1 comment
Labels
contracts Works related to contracts

Comments

@DanielVF
Copy link
Member

DanielVF commented Mar 7, 2024

We are strongly considering removing the redeem fee from OETH, moving to the only asset being WETH, and removing all oracles.

In the past, the redeem fee has provided an extra layer of protection on the protocol because any looping of minting -> doing stuff-> redeeming incurs the redeem fee cost. This erases any small profits from any calculation errors, and makes attacks requiring huge amounts of impractical unless they clear a profit threshold that gets higher the more funds are used.

We want to ensure that removing redeem fees do not result in anything that's exploitable for more than just a minimal rounding error.

There's at least two categories of attacks to consider:

  • Attacks that steal principal by minting / doing some stuff / redeeming.
  • Attacks that steal yield by minting before a rebase, then rebasing the protocol, then redeeming.

Maybe there's some kind of attack that works by redeeming first, then doing stuff, then minting? Maybe there's something with donations?

@DanielVF DanielVF added the contracts Works related to contracts label Mar 7, 2024
@DanielVF
Copy link
Member Author

DanielVF commented May 9, 2024

Done!

@DanielVF DanielVF closed this as completed May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contracts Works related to contracts
Projects
None yet
Development

No branches or pull requests

1 participant