Erroneous yield events reported in Safe account history

[micahalcorn]

I'm connected to the dapp with a Safe wallet via iOS and WalletConnect. When I open my account history, I see yield even though I have not opted-in. Both our dapp and Etherscan agree that my balance has not increased.

https://www.loom.com/share/293b59d5f321478f8db5cccd5964a5d0

This video also depicts #1404.

[HrikB]

The cause of this issue that we assume in the backend that a user/contract is opted in from the beginning so we just return all yield events.

However, I'm not sure how to solve this since rebaseOptIns and rebaseOptOuts don't emit an event and thus, aren't indexed. But the frontend is doing its job properly so I would say we should move this be an analytics issue as opposed to dapp one.

One additional thing, this is also an issue on the ousd dapp.

[micahalcorn]

See #1754 💡

[toniocodo]

@micahalcorn this should not happen on the new OETH app, can you confirm?