Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move IDataMigrationManager.UpdateAsync() to an extension method #4917

Closed
hishamco opened this issue Nov 28, 2019 · 2 comments · Fixed by #15909
Closed

Move IDataMigrationManager.UpdateAsync() to an extension method #4917

hishamco opened this issue Nov 28, 2019 · 2 comments · Fixed by #15909
Labels
enhancement
Milestone
2.x

Comments

@hishamco
Copy link
Member

While i'm working on data docs, I notice that IDataMigrationManager has two versions of UpdateAsync() one accept feature and the other one accepts a list of features

IMHO the UpdateAsync(IEumerable<string> features) could be an extension methods instead

/cc @jtkech
@Piedone
Copy link
Member

Piedone commented Apr 28, 2024

I'd rather do it the other way around: UpdateAsync(IEnumerable<string> featureIds) can (and actually does) optimize updating multiple features and do it better than just call UpdateAsync(string featureId) in a loop.

@Piedone Piedone added this to the 1.x milestone Apr 28, 2024
@hishamco
Copy link
Member Author

hishamco commented Apr 29, 2024 •
edited

Even though moving it into an extension method makes sense, then we can find a way to optimize it

@hishamco hishamco mentioned this issue Apr 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.x
2 participants
@Piedone @hishamco