Make IExternalLoginEventHandler support update User‘s properties

[hyzx86]

Summary of this PR
relate #6263
Enable the login script to generate user properties other than Roles，We can use the login script update user.properties , just like all of CustomUserSettings

• External Login Script now support update UserClaims and user's Properties
• Update description use monaco-editor
• Change the editor to monaco-editor
• Add code suggestion to editor

[hyzx86]

external login script

database

[hyzx86]

Perhaps ClaimsToUpdate should also be added?

[hyzx86]

@Skrypt @hishamco Can you help to review?

[hishamco]

@hyzx86 you could request a review from the reviewers section instead of ping in the comment. I think you already did in another PR ;)

[hishamco]

BTW some of the sugession might require a discussion before submitting a PR

[hyzx86]

BTW some of the sugession might require a discussion before submitting a PR

Yes ，here.

#7671

[hyzx86]

@hyzx86 you could request a review from the reviewers section instead of ping in the comment. I think you already did in another PR ;)

Are you talking about this ?

[sebastienros]

I like the idea of using the existing script but I am not a fan of the way it's done with merging an object. I would prefer an api like the current roles one

context.setUserProperty("FirtName", "Han");

// or

context.userProperties["FirtName"] = "Han";
context.userProperties.firstName = "Han";

[hyzx86]

@sebastienros

But if the attribute path is deep

the script will be like this?

context.setUserProperty("UserProfileInternal.UserProfilePart.FirtName.Text", "Han");

Then build the Json object with comma separation to update the existing user properties
This will lead to more checks, and it is impossible to avoid users directly assigning complex objects to an attribute

I like the idea of using the existing script but I am not a fan of the way it's done with merging an object. I would prefer an api like the current roles one

Will there be any problems if use merge?

[sebastienros]

Makes sense. Could it be "rooted" of the part though, like

{
  firstName: {
    text: "Han"
  }
}

[hyzx86]

Makes sense. Could it be "rooted" of the part though, like

My idea is to be compatible with CustomUserSettings
It does not only support specific types or properties defined in C # code, such as UserTimeZone
This design can well support any CustomUserSettings type definition

In addition, I want to add UserClaims to this function
It should be very useful when using third-party oidc authorization

[hyzx86]

@sebastienros this PR is ready to merge

[gvkries]

What is this one holding back? It would be super useful 😊

[hishamco]

@hyzx86 please fix the conflict

[hyzx86]

@hishamco Done

[hishamco]

We might need to triage this one

[github-actions]

This pull request has merge conflicts. Please resolve those before requesting a review.

[hishamco]

Could you please fix the conflict?

[Piedone]

@hishamco please bring this up on the triage meeting. The PR has been in limbo for too long.

[hyzx86]

Could you please fix the conflict?

It's updated so fast... I've fix the conflict many times 🤣, so let's talk about whether this PR is possible first, to save everyone some time

[hishamco]

@sebastienros @Piedone do you have anything here, or shall I did a final review then merge?

[Piedone]

I'm OK with it if you're OK.

[hishamco]

@hyzx86 please react to the latest changes then I can merge, I know if you wait a merge conflict will show up :)

[github-actions]

This pull request has merge conflicts. Please resolve those before requesting a review.

[hyzx86]

@hyzx86 please react to the latest changes then I can merge, I know if you wait a merge conflict will show up :)

Done , It's finally going to be merged into the main branch. I'm looking forward to it. 🎉🎉🎉🎉🎉🎉

[hishamco]

@hyzx86 finally it has been merged :) thanks for your patient and contribution