Replies: 3 comments 6 replies
-
Unless there is a need for that I would say it is not necessary but of course, that would be cleaner. |
Beta Was this translation helpful? Give feedback.
-
@hishamco not sure I follow but I guess OrchardCore.Liquid.Abstractions is based on Fluid and It had nothing to do with other liquid implementation If someone needs different implementation of liquid I don’t think they may be able to to use this abstraction |
Beta Was this translation helpful? Give feedback.
-
What I meant there is mostly that there is no need for a second Liquid parser as Fluid is the best. 😉 |
Beta Was this translation helpful? Give feedback.
-
If we look closely into
OrchardCore.Liquid.Abstractions
it has a dependency on Fluid, which is one of the implementations for Liquid, I suggest to rename the project intoOrchardCore.Liquid.Core
or keep the intefaces that not have depedency on Fluid and move the others into core@sebastienros your thought
Beta Was this translation helpful? Give feedback.
All reactions