Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use eCommerce theme (OCC-161) #300

Open
hishamco opened this issue May 31, 2023 · 13 comments
Open

Use eCommerce theme (OCC-161) #300

hishamco opened this issue May 31, 2023 · 13 comments
Labels
enhancement New feature or request

Comments

@hishamco
Copy link
Member

hishamco commented May 31, 2023

it would be nice to use eCommerce theme instead of building on top of the Blog theme. We could use something like https://startbootstrap.com/templates/ecommerce I can submit a PR if the team agrees with the idea

Jira issue

@hishamco hishamco added the enhancement New feature or request label May 31, 2023
@github-actions github-actions bot changed the title Use eCommerce theme Use eCommerce theme (OCC-161) May 31, 2023
@hishamco
Copy link
Member Author

@Piedone can I have access to this repo in case I need to push a PR, or shall I fork, then commits from the forked repo?

@Piedone
Copy link
Member

Piedone commented Jun 15, 2023

@DAud-IcI is the project leader here, so Dávid please advise,

@sarahelsaig
Copy link
Contributor

I don't mind. @hishamco, I've added you to the developers group, please check if you have the access.

@hishamco
Copy link
Member Author

Hope to contribute to the repo in the upcoming future, thanks David

@agriffard
Copy link
Member

IMHO, if you don't have the time to invest in a dedicated Commerce theme, TheTheme would be a better default choice than TheBlogTheme.

@sarahelsaig
Copy link
Contributor

What's the advantage of using TheTheme vs TheBlogTheme?

@agriffard
Copy link
Member

agriffard commented Sep 16, 2023

The default recipe that you provide is meant to show the features than the module offers.
You should focus on demonstrating to first time users what they would expect from an ECommerce module (Product listing on homepage, search, product details, add to cart).

Using TheBlogTheme can be kind of a misguiding distraction for the user.
One way to showcase only the features would be to use the default theme.

But then, I guess we all agree that the most fitted UI would be a simple commerce theme as Hisham suggested:

  • Site Name, Menu, Cart link at the top.
  • Product list (That is why is suggested to add a MediaField)
  • Product details (Description, Attributes, Variants)
  • Cart page

@sarahelsaig
Copy link
Contributor

For anyone taking this:
move the Modules/OrchardCore.Commerce/Assets/Styles/general/_error.scss into the theme instead.

@hishamco
Copy link
Member Author

hishamco commented Jan 4, 2024

@sarahelsaig can I add this theme to https://github.com/OrchardCoreContrib/OrchardCoreContrib.Themes then we could override the views (something similar to the blog theme) or shall we add it into the repo

@sarahelsaig
Copy link
Contributor

You can add a base theme into OrchardCoreContrib.Themes if that helps your workflow, but the theme and the OCC-specific views should be in this repo. Or did you mean something else?

@hishamco
Copy link
Member Author

hishamco commented Jan 5, 2024

but the theme and the OCC-specific views should be in this repo

Sure, or we could override them, let me have a deep look to the current customization in TheBlog theme then I can follow it

@Piedone
Copy link
Member

Piedone commented Jan 11, 2024

Note for when this is done: check if allowInlineStyle is still needed in Program.

@hishamco
Copy link
Member Author

I will busy nowadays with revising and finalizing OC PRs then I can have time for other related OC stuff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants