Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle multiple totals in different currencies (OCC-64) #132

Open
DemeSzabolcs opened this issue Jul 31, 2022 · 3 comments
Open

Handle multiple totals in different currencies (OCC-64) #132

DemeSzabolcs opened this issue Jul 31, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@DemeSzabolcs
Copy link
Contributor

DemeSzabolcs commented Jul 31, 2022

Part of #16 followup to #127. We can only pay in one currency at a time. Later we have to figure out what to do if there are multiple totals i.e., multiple currencies. A solution could be to convert the totals in other currencies to one.

Jira issue

@DemeSzabolcs DemeSzabolcs added the enhancement New feature or request label Jul 31, 2022
@Piedone
Copy link
Member

Piedone commented Aug 1, 2022

Do we really need this? While having the ability to use anyone currency in a shop is necessary, and later perhaps we can add the ability to add prices in multiple currencies and be able to switch between them (or rather, convert automatically) as just a nice to have feature, I don't see when doing a checkout with multiple currencies in the basket would make sense.

@sarahelsaig
Copy link
Contributor

sarahelsaig commented Aug 1, 2022

Depends on what you mean by "this". :) The feature not urgent at all, but we need the issue "for the record". It's a known undefined case that could potentially cause problems and an issue is better than just a comment in the codebase.

@Piedone
Copy link
Member

Piedone commented Aug 1, 2022

"This" = having multiple totals :). The checkout should calculate (i.e present to the user) prices in a single currency. If we have a situation where there are items with multiple currencies in the DB then we should handle that somehow properly indeed.

@github-actions github-actions bot changed the title Handle multiple totals in different currencies Handle multiple totals in different currencies (OCC-64) Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants