Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Orchard.OutputCache shouldn't handle cache invalidation in the settings part handler #7958

Closed
carlwoodhouse opened this issue Feb 1, 2018 · 1 comment
Closed

Orchard.OutputCache shouldn't handle cache invalidation in the settings part handler #7958

carlwoodhouse opened this issue Feb 1, 2018 · 1 comment
Milestone
Orchard 1.10.3

Comments

@carlwoodhouse
Copy link
Member

carlwoodhouse commented Feb 1, 2018 •
edited

At the moment the invalidation of items from orchard's output cache is handled by hooking into event's in the CacheSettingsPartHandler (https://github.com/OrchardCMS/Orchard/blob/master/src/Orchard.Web/Modules/Orchard.OutputCache/Handlers/CacheSettingsPartHandler.cs)

It would be better if these 3 events weere in a separate handler, this would make it easier to suppress these event's if doing custom stuff with cache invalidation without effecting the settingspart. Really these events have nothing to do with the settings.

Can provide a PR if considered a good idea.
@carlwoodhouse carlwoodhouse changed the title Orchard.OutputCache shouldn't handle cache invalidation in the settings part driver Orchard.OutputCache shouldn't handle cache invalidation in the settings part handler Feb 1, 2018
carlwoodhouse pushed a commit to carlwoodhouse/Orchard that referenced this issue Feb 1, 2018
Decoupled cache eviction from cache settings handler OrchardCMS#7958
b5c26b8
@carlwoodhouse
Copy link
Member Author

PR of what i'm proposing here : #7959

@sebastienros sebastienros added this to the Orchard 1.10.x milestone Feb 1, 2018
sebastienros pushed a commit that referenced this issue Feb 1, 2018
@carlwoodhouse @sebastienros
Decoupled cache eviction from cache settings handler fixes #7958 (#7959)
fcaaac3
@BenedekFarkas BenedekFarkas modified the milestones: 1.10.x, Orchard 1.10.3 Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Orchard 1.10.3
Development

No branches or pull requests
3 participants
@carlwoodhouse @sebastienros @BenedekFarkas