Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remaining issues with tests #270

Open
aaron-junot opened this issue Jan 10, 2020 · 3 comments
Open

Fix remaining issues with tests #270

aaron-junot opened this issue Jan 10, 2020 · 3 comments

Comments

@aaron-junot
Copy link
Member

In #266 we made a lot of improvement on the tests, but we had to throw in the towel on a few of the issues:

  1. The search tests might not be testing anything. See Refactors test_routes as a separate module #266 (comment)

  2. There's almost certainly a better abstraction for test_algolia_exception_error and test_algolia_unreachable_host_error because they are the exact same test, just with different fake errors returned from algolia. Someone can go in and abstract out the similarities and perhaps inject the mocks just where they're needed to cut down on the code and/or execution time. See Refactors test_routes as a separate module #266 (comment)

  3. We were never able to implement test_false_validation due to problems mocking the correct function. I'm not sure if it was our implementation or perhaps a bug in pytest-mock, but it just wasn't working for us. If you can make it work, we'd love this test to exist. See Refactors test_routes as a separate module #266 (comment)

@aaron-junot
Copy link
Member Author

@rooshs481 is going to take this one on

@fumblehool
Copy link

I think nobody is currently working on this. @aaron-suarez Can I work on this?

@aaron-junot
Copy link
Member Author

Go ahead @fumblehool !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants