Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some trains missing from API #177

Open
CedricReichenbach opened this issue Sep 4, 2017 · 2 comments
Open

Some trains missing from API #177

CedricReichenbach opened this issue Sep 4, 2017 · 2 comments

Comments

@CedricReichenbach
Copy link
Contributor

I just noticed that some trains seem to have disappeared from the API recently, even though they're still reported by the SBB website.

One that's reproducable is the S 4 from Bern to Thun at 23:46 (bottom one in screenshot):
bildschirmfoto vom 2017-09-04 um 21 12 17

The output of http://transport.opendata.ch/v1/connections?from=bern&to=thun&time=23:40 contains the S 1 train and a later IC, but not the S 4.

This problem likely roots in the search.ch API, which doesn't report any S 4 for the corresponding request: https://fahrplan.search.ch/api/route.json?from=Bern&to=Thun&time=23:40

Since when?

As it happens, I think the missing connection was still reported correctly on July 10, so a regression must have been introduced with a change in that time frame since then.

A wild guess

The S 1 and the S 4 look quite similar data-wise, e.g. both depart at the same time. Maybe some duplicate removal mechanism kicked in too eagerly.

@helbling
Copy link

helbling commented Sep 5, 2017

S4 is still there (see departure table) just not for this query because you are 30% slower and seems to have no benefit at all compared to S1.

@CedricReichenbach
Copy link
Contributor Author

@helbling Ok, so it's filtered out. It might have benefits in some occasions, e.g. if occupation is higher in the S1, or if the traveler prefers one route over the other (e.g. for sightseeing).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants