Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CDSS Tools Python code for Python 3 #20

Open
smalers opened this issue Apr 7, 2021 · 0 comments
Open

Update CDSS Tools Python code for Python 3 #20

smalers opened this issue Apr 7, 2021 · 0 comments
Assignees
Labels
critical Priority: highest priority enhancement M Size: 2-3 days

Comments

@smalers
Copy link
Contributor

smalers commented Apr 7, 2021

The existing Python code in pycharm-project needs to be updated from Python 2 to Python 3 and perform similar to before. The following are technical considerations.

  1. Do basic Python updates for version 2 -> 3 syntax and common packages.
  2. Make sure that Python3 is being found, for example use python3 instead of python.
  3. Review the code and respond to PyCharm PEP warnings.
  4. Make sure that the step to upload files to cloud is configurable to use OWF AWS S3 storage bucket as well as State's GCP bucket, and for our testing only use AWS S3. Testing with local files is also OK.
  5. Previously we developed and tested on Windows and deployed to GCP Ubuntu. Now we are developing and testing on Linux VB before deploying. It may be necessary to improve how the application is packaged and deployed locally so that it can be tested in deployed form. For example, this can be done with a simple bash script to tar up files, and then untar to install. Or we can try to use something like makeself. It may be worth using a Python virtual environment like GeoProcessor, but let's evaluate that once basic cleanup is done.
@smalers smalers added enhancement critical Priority: highest priority M Size: 2-3 days labels Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
critical Priority: highest priority enhancement M Size: 2-3 days
Projects
None yet
Development

No branches or pull requests

2 participants