Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

security warning when compiling with: -Wformat -Werror=format-security #198

Open
x3oo opened this issue Sep 6, 2021 · 3 comments · May be fixed by #221
Open

security warning when compiling with: -Wformat -Werror=format-security #198

x3oo opened this issue Sep 6, 2021 · 3 comments · May be fixed by #221

Comments

@x3oo
Copy link

x3oo commented Sep 6, 2021

openvsp stopped compiling most likely its the flag:
-Wformat -Werror=format-security
those are my flags. i am on archlinux:
CFLAGS="-march=native -O2 -pipe -fno-plt -fexceptions
-Wp,-D_FORTIFY_SOURCE=2
-fstack-clash-protection -fcf-protection"
CXXFLAGS="$CFLAGS -Wp,-D_GLIBCXX_ASSERTIONS"

currently recompiling.

similar bug as context:
https://stackoverflow.com/questions/17260409/fprintf-error-format-not-a-string-literal-and-no-format-arguments-werror-for

https://pastebin.pl/view/cc49a8ca
@x3oo
Copy link
Author

x3oo commented Sep 6, 2021

trying to recompile without the flag

@x3oo
Copy link
Author

x3oo commented Sep 6, 2021

looks like it worked

@x3oo
Copy link
Author

x3oo commented Sep 6, 2021

i think this is potentially a security bug.

@acxz acxz mentioned this issue Sep 7, 2021
Open
@x3oo x3oo changed the title recent openvsp stopped compiling security warning when compiling with: -Wformat -Werror=format-security Sep 7, 2021
@acxz acxz linked a pull request Jan 27, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

disable -Werror=format-security acxz/OpenVSP
1 participant
@x3oo