Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github crash report doesn't fill crash data in template #1738

Open
sgofferj opened this issue Oct 17, 2023 · 11 comments
Open

Github crash report doesn't fill crash data in template #1738

sgofferj opened this issue Oct 17, 2023 · 11 comments
Labels
potential bug A bug that could not (yet) be reproduced

Comments

@sgofferj
Copy link

Describe the bug
When OT crashes, there's a bug button which should open a bug report on Github. Well, it does but it leads to the bug template selection but when "bug" is selected, the information previously seen on the screen is not filled into the template.

To Reproduce

  1. Crash the app
  2. Click on the bug
  3. Choose a template
  4. See error

Technical information

App information

  • ID: de.dennisguse.opentracks.nightly
  • Version: 5483 v4.9.2-17-g8f9ba046c

Device information

  • Brand: ulefone
  • Device: Armor_3
  • Model: Armor_3
  • Id: O11019
  • Product: Armor_3

Firmware

  • SDK: 27
  • Release: 8.1.0
  • Incremental: 1535356309
@sgofferj sgofferj added the potential bug A bug that could not (yet) be reproduced label Oct 17, 2023
@dennisguse
Copy link
Member

Are you using the Github App or the Webpage?

@pstorch FYI

@pstorch
Copy link
Member

pstorch commented Oct 17, 2023

Hmm, maybe we have to add the issue template parameter to the report_issue_link like "&template=bug_report.md"

@sgofferj
Copy link
Author

@dennisguse I have the github app installed at least. I check on the next crash, what actually gets opened.

@pstorch
Copy link
Member

pstorch commented Oct 17, 2023

I cannot reproduce. When I send a bug report via browser (Firefox), I don't see the template selection and the issue contains all the info.
What is the difference?

Edit:
I also tried adding the template parameter to the URL. With it, I see that the template was chosen, but the content is still the same from the bug reporter.
Should I send a PR with this change?

@sgofferj
Copy link
Author

Checked today when it crashed again. It's opening the GitHub app, not GitHub in a browser.

@dennisguse
Copy link
Member

@sgofferj did you update to the newest nightly?

@sgofferj
Copy link
Author

I thought I did. Checking now.

@sgofferj
Copy link
Author

Well, now that I updated to latest nightly, OT is not crashing anymore, so I can't test the interaction with the Github app anymore...

@dennisguse
Copy link
Member

I just made OpenTracks crash and the Github app is opened, but requesting to select a template.
After selecting the template, just the template is shown (not the OpenTracks provided body).

@pstorch
Copy link
Member

pstorch commented Oct 21, 2023

I didn't had the Github App, only tested via browser.
I now installed the Github App to test. When I provoke a crash the Github App opens with the issue without the template selection, but it misses the stacktrace in the issue description.

Edit: not only the stacktrace is missing, also the last section "Firmware". So I guess there is a limitation in the app.

@pstorch
Copy link
Member

pstorch commented Oct 24, 2023

@dennisguse can you test with disabled Github App, so the browser opens the page?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
potential bug A bug that could not (yet) be reproduced
Projects
None yet
Development

No branches or pull requests

3 participants