New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include uri in pkcs11-tool -L option #3125
Include uri in pkcs11-tool -L option #3125
Conversation
3558894
to
c27e972
Compare
I have also cross-checked the output with other tools, and it seems reasonable: $ systemd-cryptenroll --pkcs11-token=list; ./src/tools/pkcs11-tool -L | grep uri | awk -F ': ' '{print $NF}'
| tr -d ' '
URI LABEL MANUFACTURER MODEL
pkcs11:model=PKCS%2315%20emulated;manufacturer=piv_II;serial=abcdef1234567890;token=clevis clevis piv_II PKCS#15 emulated
pkcs11:model=PKCS%2315%20emulated;manufacturer=piv_II;serial=abcdef1234567890;token=clevis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
5c0c15b
to
b645d41
Compare
Fixes: OpenSC#3123 Signed-off-by: Sergio Arroutbi <sarroutb@redhat.com>
b645d41
to
700b6e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good to go.
One possible area to extend this could be printing the URI for the objects too (which could reuse most of the current code) and some test coverage to see the URIs printed make sense. Should be quite easy to start from for example tests/test-pkcs11-tool-import.sh
and grep for the important uri parts.
Co-authored-by: Jakub Jelen <jakuje@gmail.com>
Sure. I will open an issue for it and I will create a PR for that. Thanks for your help, @Jakuje |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Lets wait if others will have some comments and if not, I will merge it next week.
Thank you for your contribution! |
Hello Jakub. I opened #3129 for this extension. |
Fixes: #3123
Tests performed with Yubico Yubikey 5 NFC: