Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a dart compatible oauth library #4

Open
MoralCode opened this issue Feb 15, 2024 · 6 comments
Open

Find a dart compatible oauth library #4

MoralCode opened this issue Feb 15, 2024 · 6 comments

Comments

@MoralCode
Copy link
Contributor

turns out https://pub.dev/packages/oauth2_client uses the flutter SDK not strictly dart.

this is breaking CI

@MoralCode MoralCode mentioned this issue Feb 15, 2024
@MoralCode
Copy link
Contributor Author

MoralCode commented Feb 15, 2024

another option includes simply reclassifying this as a Flutter library. which may or may not be a good choice

@MoralCode
Copy link
Contributor Author

For the webhook usecase, tokens probably dont need to be persisted once the hook is set up as the data will simply arrive.

For other usecases we may need to find a way for the consumer of this library to be responsible for persistence

@MoralCode
Copy link
Contributor Author

Having a library boundary between the code that persists tokens to secure storage and the code that uses those tokens seems to be a programming/design pattern I haven't seen before. More research may be needed on how best to do this

@MoralCode
Copy link
Contributor Author

tbh im sorta leaning towards https://pub.dev/packages/oauth2 since it looks like its made by dart themselves

@MoralCode
Copy link
Contributor Author

MoralCode commented Feb 21, 2024

hmmm that library may not be great... dart-lang/oauth2#87

will experiment and see how it goes

@MoralCode
Copy link
Contributor Author

this library has been found and imported, it just needs to be integrated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant