Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old version removes newly added settings #7724

Open
telk5093 opened this issue Jun 21, 2018 · 3 comments
Open

Old version removes newly added settings #7724

telk5093 opened this issue Jun 21, 2018 · 3 comments
Labels
enhancement An improvement to an existing feature (no alteration). technical restriction Game cannot do it due to internal limitations that would be hit.

Comments

@telk5093
Copy link
Contributor

OS: Windows 10
Version: 0.2.0
Commit/Build: c640427

I both use 0.2.0 and 0.1.2 because I have to take a screenshot with korean scenario text correctly, to avoid #7533.
But after I use 0.1.2, new configurations (such as Virtual floor, Twitch API URL) are gone. It's very uncomfortable for me.

I have doubt if it will be enhanced in next master version.

Steps to reproduce:

  1. Run the latest develop version, such as 0.2.0
  2. Set Virtual floor setting to None or Transparent, which is not default. Or input Twitch API URL.
  3. Terminate game, and rollback to 0.1.2
  4. Run game once.
  5. Update game to 0.2.0 again
  6. Run game again, then Virtual floor setting and Twitch API URL settings are gone.
@telk5093 telk5093 changed the title Old version removes new configs Old version removes newly added settings Jun 21, 2018
@AaronVanGeffen
Copy link
Member

I'm afraid this is not going to change, as the config loading routine will only load settings it recognises. We certainly cannot change this retroactively for older versions.

I agree #7533 should be fixed, though. I'd do it myself, but I'm not a Windows user.

This issue, however, I'm inclined to close. I don't see this behaviour changing anytime soon.

@janisozaur
Copy link
Member

As a workaround you could keep a copy of your settings and redirect the older version with --user-data-path. If you don't change settings often, maybe you could mark config.ini as read-only.

@spacek531
Copy link
Contributor

@AaronVanGeffen I think he's asking if the loading scheme can be changed so it ignores invalid/unknown settings rather than stripping them from the config.

@Gymnasiast Gymnasiast added enhancement An improvement to an existing feature (no alteration). technical restriction Game cannot do it due to internal limitations that would be hit. labels Jun 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement to an existing feature (no alteration). technical restriction Game cannot do it due to internal limitations that would be hit.
Projects
None yet
Development

No branches or pull requests

5 participants