Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mod display name with special symbols breaks MacOS packaging #186

Open
penev92 opened this issue Feb 27, 2023 · 0 comments
Open

Mod display name with special symbols breaks MacOS packaging #186

penev92 opened this issue Feb 27, 2023 · 0 comments
Labels

Comments

@penev92
Copy link
Member

penev92 commented Feb 27, 2023

First reported by @MustaphaTR and his D2k mod, an investigation concluded that the MacOS packaging script can break if the PACKAGING_DISPLAY_NAME in mod.config contains a '\'' (the mod was called "MustaphaTR's D2k Mod".
The Windows installer and Linux AppImages build successfully regardless.

The issue seems to be after https://github.com/OpenRA/OpenRAModSDK/blob/master/packaging/macos/buildpackage.sh#L108 and can likely easily be resolved by escaping input strings.

@penev92 penev92 added the Bug label Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant