Correct launch-game.cmd join of quoted paths #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unquote strings in launch-game.cmd and quote on use. Now correctly finds directory when there are quotes in the mod.config files.
abcdefg30
reviewed
Sep 24, 2023
|
The default git diff mod.config
diff --git a/mod.config b/mod.config
index 7c0ab03..f5a0aab 100644
--- a/mod.config
+++ b/mod.config
@@ -9,7 +9,7 @@
MOD_ID="example"
# The OpenRA engine version to use for this project.
-ENGINE_VERSION="release-20230225"
+ENGINE_VERSION="engine"
##############################################################################
# Packaging |
|
It does create it and write the string into the |
abcdefg30
reviewed
Sep 25, 2023
| >nul find %ENGINE_VERSION% %ENGINE_DIRECTORY%\VERSION || goto noengine | ||
| cd %ENGINE_DIRECTORY% | ||
| if not exist "%ENGINE_DIRECTORY%\bin\OpenRA.exe" goto noengine | ||
| >nul find %ENGINE_VERSION% "%ENGINE_DIRECTORY%\VERSION" || goto noengine |
There was a problem hiding this comment.
Suggested change
| >nul find %ENGINE_VERSION% "%ENGINE_DIRECTORY%\VERSION" || goto noengine | |
| >nul find "%ENGINE_VERSION%" "%ENGINE_DIRECTORY%\VERSION" || goto noengine |
Fixes the issue.
There was a problem hiding this comment.
Seems like it will treat the version string as a file name without the quotations, which lead to the error I had yesterday.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unquote strings in launch-game.cmd and quote on use. Now correctly finds directory when there are quotes in the mod.config files.
fixes #175