VNC autorestart patch

[dann1]

Somehow OpenNebula kills the VNC server started during deploy fase. Sometimes you may get Server Disconnection when logged via noVNC in Sunstone. This is solved by pressing f5 reloading the tab in your browser. What happens behind the scenes is

addon-lxdone/src/remotes/vmm/lxd/vnc.bash

Lines 8 to 12 in 7bc9b16

	while [[ $(lxc info one-$VM_ID | grep Status | awk {'print $2'}) == "Running" ]]; do
	svncterm -timeout 0 -rfbport $VNC_PORT -c lxc exec one-$VM_ID login || ((counter=counter+1))
	if [[ $counter -eq 6 ]]; then exit
	fi
	done

This basically starts the VNC server associated to a one-container whenever its killed. The problem is VNC server shouldn't be restarted because it shouldn't be killed in the first place. We don't know why it's been killed but we think it has something to do with OpenNebula because manually starting the VNC and not entering via Sunstone keeps the server alive. We used tigervnc client and it wouldn't die.

Resuming, the vnc.bash patch works but things could be better. Any ideas would be welcomed.