Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend mxCheckIdentification() for definition variables #386

Open
mhunter1 opened this issue Feb 11, 2024 · 1 comment
Open

Extend mxCheckIdentification() for definition variables #386

mhunter1 opened this issue Feb 11, 2024 · 1 comment
Assignees

Comments

@mhunter1
Copy link
Contributor

This is going to be a multistep process:

  • mxCheckIdentification() is in R/MxExpectationNormal.R
  • Find all definition variables. Needs to happen by variable name and by dataset (possibly multiple data objects in a model).
  • Write function to find what all the definition variables are
  • Change all definition variables to free parameters
  • Some definition variables occur in matrices.
  • Some occur in algebras.
  • The definition variables in algebras can be converted to 1x1 matrices as in R/MxAlgebraConvert.R and the function insertDefinitionVariable().
  • This generally may need to to a lot of the same processing that is currently done in mxRun().
  • Add argument defvar.row to mxCheckIdentification().
  • Make sure this argument is passed through to omxModelByParameterJacobian() and the constraint function.
  • Document special behavior of defvar.row. Takes a single numeric value, or a function that chooses definition variable rows.
  • Write function to choose definition variable rows. 25th percentile of each variable. When another value is needed add the 75th percentile (or the next higher value that is distinct from the first value).
  • definitionStartingValue in R/DefinitionVars.R
  • What happens if there are definition variables in multiple groups? X1 in group 1, X2 in group 2. No assurance that X1 and X2 have the same number of rows or that rows align such that a correlation between X1 and X2 is meaningful. Maybe assume X1 and X2 are correlated 0?
@mhunter1 mhunter1 self-assigned this Feb 11, 2024
@mcneale
Copy link
Contributor

mcneale commented Feb 14, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants