Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error handling isn't correct #2

Open
cereallarceny opened this issue May 15, 2018 · 0 comments
Open

Error handling isn't correct #2

cereallarceny opened this issue May 15, 2018 · 0 comments
Labels
Good first issue 🎓 Perfect for beginners, welcome to OpenMined! help wanted Extra attention is needed Type: New Feature ➕ Introduction of a completely new addition to the codebase

Comments

@cereallarceny
Copy link
Member

Sometimes we return error, sometimes we return errorMessage. It depends. Regardless, I'm a bit lost in async/await action that I'm not quite sure where I should be catching and throwing errors. We should have a single resolver that handles errors on an API-to-API basis and reports them to SNS accordingly.
@cereallarceny cereallarceny added Type: New Feature ➕ Introduction of a completely new addition to the codebase help wanted Extra attention is needed Good first issue 🎓 Perfect for beginners, welcome to OpenMined! labels May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good first issue 🎓 Perfect for beginners, welcome to OpenMined! help wanted Extra attention is needed Type: New Feature ➕ Introduction of a completely new addition to the codebase
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cereallarceny