Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

liberty-maven-plugin should rely on the build toolchain configuration to build / rebuild code #1781

Open
andre-doherty opened this issue Dec 19, 2023 · 3 comments

Comments

@andre-doherty
Copy link

Hello,

I am noticing the following behavior when using the liberty maven plugin in dev mode.

Description of the issue :
The jdk used to invoke maven is used to build / rebuild code (such as unit tests) regardless of the build toolchain that maven is build upon.

How it should behave :
Whenever a build toolchain configuration is defined in the maven setup it should be used by the liberty-maven-plugin
see : https://cwiki.apache.org/confluence/display/MAVENOLD/Toolchains

Regards,
André

@scottkurz
Copy link
Member

Agreed. We have #1630 open as well though haven't prioritized it yet.

@andre-doherty
Copy link
Author

Sorry i didn't spot that one.
Yeah that's an issue for instance when you have to deal with jdk8 and below component, eg when the running jdk doesnt have jaxb / jaxws support as in jdk11+, units tests wont even compile when in dev mode whenever they are perfectly ok in a basic mvn clean install use case.

@scottkurz
Copy link
Member

scottkurz commented Dec 19, 2023

Sorry i didn't spot that one.

No problem. I won't promise anything exactly but I'll remind the team to take another look as we prioritize in 2024. Thanks for bringing this up again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants