Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling editor theme #115

Open
2 of 4 tasks
Pratibha-Goyal opened this issue Apr 12, 2018 · 7 comments · May be fixed by #117
Open
2 of 4 tasks

Styling editor theme #115

Pratibha-Goyal opened this issue Apr 12, 2018 · 7 comments · May be fixed by #117

Comments

@Pratibha-Goyal
Copy link
Member

I'm submitting a ... (check one with "x")

  • bug report
  • feature request

Description:
Customising the code space.

Expected Behavior:
This might improve the visual appearance of the code space and make it suitable to user's preference.

Actual Behavior:
The user can toggle between the themes accordingly.

Screenshots (if any):
subblack
subwhite

Would you like to work on this issue?

  • Yes
  • No
@Pratibha-Goyal Pratibha-Goyal linked a pull request Apr 12, 2018 that will close this issue
2 tasks
@YousraDesoukey
Copy link

My team would like to implement this feature. Is it possible?

@AdiChat
Copy link
Member

AdiChat commented Apr 15, 2018

@YousraDesoukey Thanks for expressing your interest 👍 but a pull request regarding this feature has been sent. You may take a look at other scopes of contribution. There are plenty ✨

@YousraDesoukey
Copy link

@AdiChat Thank you for replying, but there are 12 issues and 13 pull requests, We think most of the features are already implemented. Then, what should we do so we can contribute?

@AdiChat
Copy link
Member

AdiChat commented Apr 15, 2018

@YousraDesoukey There are some pull requests whose changes have been delayed. If you want, you can continue one of them. For instance, you can take a look at this feature issue (and the associated pull request to get an idea) as this will be relatively easy to begin with. Keep us informed on your plan 👍

Apart from that, you can suggest your own features by opening a feature issue and start working on them. We will be adding new easy to work on feature issues soon to make the contribution process smoother. 😄

@YousraDesoukey
Copy link

@AdiChat That's a great suggestion, thanks for your help. My team will try to work on this feature.

@YousraDesoukey
Copy link

@AdiChat We implemented the feature you suggested and made a pull request, and there were no conflicts. However, the Travis CI build has failed. It says that "all checks have failed", and we're not sure why this happened. Could you please help us with this problem?

@AdiChat
Copy link
Member

AdiChat commented Apr 18, 2018

@YousraDesoukey Sure. It looks like that there are styling issues. You can view the error here which claims The command "flake8 ." exited with 1..

Formatting your code to conform to the PEP 8 style guide should solve this. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants