Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

color changed toggle #117

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Pratibha-Goyal
Copy link
Member

Checklist

  • My branch is up-to-date with the upstream develop branch.
  • I have added necessary documentation (if appropriate).

Which issue does this PR fix?:
fixes: #115

Why do we need this PR?:
This customises the appearance of code results which might enhance the readability
according to a user. This adds visual effect to the existing code space.

If relevant, please include a screenshot.

black

white

@Pratibha-Goyal
Copy link
Member Author

@AdiChat please review.

@@ -2,6 +2,7 @@
{% block head %}
<title>"cosmos-search</title>
<link rel="stylesheet" href="//cdn.jsdelivr.net/gh/highlightjs/cdn-release@9.12.0/build/styles/sunburst.min.css">
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.3.1/jquery.min.js"></script>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may include this JS file at the end of this file. 👍

@AdiChat
Copy link
Member

AdiChat commented Apr 19, 2018

Nice work. 👍

Kindly make the above change and it will be good to be merged 👍

@Pratibha-Goyal
Copy link
Member Author

@AdiChat please review, I have made the necessary changes.

@AdiChat
Copy link
Member

AdiChat commented Apr 22, 2018

Nice work 👍

There seems to be a black coloured space between the code and the number line in the white theme. Ideally, it should be of the same background colour.

Kindly take a look into it. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Styling editor theme
2 participants