Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SwapTradeCsvPlugin: not parsing XCcy ON/ON #2527

Open
marc-henrard opened this issue Oct 22, 2022 · 1 comment
Open

SwapTradeCsvPlugin: not parsing XCcy ON/ON #2527

marc-henrard opened this issue Oct 22, 2022 · 1 comment

Comments

@marc-henrard
Copy link
Contributor

SwapTradeCsvPlugin: does not parse cross-currency swaps with "XCcyOvernightOvernightSwapConvention".

At line 350:
if (fxRateOpt.isPresent()) {
XCcyIborIborSwapConvention convention = XCcyIborIborSwapConvention.of(conventionStr);

Does not check for the possible ON/ON conventions.

Would probably be a good idea to have a "XCcySwapConvention" in parallel to "SingleCurrencySwapConvention"

@marc-henrard
Copy link
Contributor Author

This is an issue only when the trades are loaded using the "convention" field. When the details of each leg are provided, this is not an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant