Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]Support advanced http router and features #51

Closed
lizzzcai opened this issue Jun 13, 2022 · 0 comments · Fixed by #52
Closed

[Feature]Support advanced http router and features #51

lizzzcai opened this issue Jun 13, 2022 · 0 comments · Fixed by #52
Labels
enhancement New feature or request priority/medium

Comments

@lizzzcai
Copy link
Member

  1. use mux as the default handler in ff-go which is more production-ready and we can bring in new features - Create Functions Framework Spec functions-framework#21 (comment), Serve multipe routes on the same function functions-framework#17
  2. support defining variables in the path like /functions/<funcname>, and use it in the function by ofnctx.Vars()
  3. support defining method matcher like withFunctionMethods("GET", "POST")
@benjaminhuo benjaminhuo added enhancement New feature or request priority/medium labels Jun 13, 2022
lizzzcai added a commit to lizzzcai/functions-framework-go that referenced this issue Jun 18, 2022
@lizzzcai
add mux as http router. add support to path methods and variables. re…
9013f1a 
…fine some features. fix some issues. add tests.

close OpenFunction#51

Signed-off-by: Lize Cai <lize.cai@sap.com>
@lizzzcai lizzzcai mentioned this issue Jun 18, 2022
Merged
benjaminhuo pushed a commit that referenced this issue Jun 28, 2022
@lizzzcai
Support defining variables and methods and fix some issues (#52)
d08c60f 
* add mux as http router. add support to path methods and variables. refine some features. fix some issues. add tests.
close #51

Signed-off-by: Lize Cai <lize.cai@sap.com>

* update tests

Signed-off-by: Lize Cai <lize.cai@sap.com>

* fix typo, rename functions, and add test for structured and binary cloud event

Signed-off-by: Lize Cai <lize.cai@sap.com>
@benjaminhuo benjaminhuo mentioned this issue Aug 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request priority/medium
Projects
Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support defining variables and methods and fix some issues lizzzcai/functions-framework-go
2 participants
@benjaminhuo @lizzzcai