Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identify as open-mastr package when requesting data from marktstammdatenregister.de #489

Closed
FlorianK13 opened this issue Mar 5, 2024 · 3 comments
Closed

Identify as open-mastr package when requesting data from marktstammdatenregister.de #489

FlorianK13 opened this issue Mar 5, 2024 · 3 comments
Labels
good first issue This issue is suitable for a first time contribution 👐 help wanted Extra attention is needed

Comments

@FlorianK13
Copy link
Member

We could add a small identification in the request header to identify as python package user when the data is requested from BNetzA.
@maurerle
Copy link

This should be done setting by setting a User-Agent like open-mastr/x.x requests/y.y python/z.z in the requests call and similar to the header in:
https://github.com/OpenEnergyPlatform/open-MaStR/blob/production/open_mastr/xml_download/utils_download_bulk.py#L125

@FlorianK13
Copy link
Member Author

@maurerle I also think this is the right approach. Due to limited resources this was not done yet. If you wish to contribute we are always happy about Pull Requests :)

@FlorianK13 FlorianK13 added 👐 help wanted Extra attention is needed good first issue This issue is suitable for a first time contribution labels May 7, 2024
FlorianK13 added a commit that referenced this issue May 16, 2024
@FlorianK13
Add header to request #489
12ae226
@FlorianK13 FlorianK13 mentioned this issue May 16, 2024
Closed
5 tasks
@FlorianK13 FlorianK13 linked a pull request May 16, 2024 that will close this issue
Feature 489 requests identify as open mastr #519
Closed
5 tasks
FlorianK13 added a commit that referenced this issue May 16, 2024
@FlorianK13
Update Changelog #489
f71217e
FlorianK13 added a commit that referenced this issue May 23, 2024
@FlorianK13 @chrwm
Make HEADERS a constant #489
1d0d611 
Co-authored-by: chrwm <54852694+chrwm@users.noreply.github.com>
FlorianK13 added a commit that referenced this issue May 23, 2024
@FlorianK13 @chrwm
Make HEADERS a constant #489
3b142c7 
Co-authored-by: chrwm <54852694+chrwm@users.noreply.github.com>
FlorianK13 added a commit that referenced this issue May 23, 2024
@FlorianK13 @chrwm
Make HEADERS a constant #489
d8a3ca5 
Co-authored-by: chrwm <54852694+chrwm@users.noreply.github.com>
@maurerle maurerle mentioned this issue May 26, 2024
Merged
5 tasks
@maurerle
Copy link

Don't know what went wrong, as the merged PR #526 stated
closes #489 - but it did not close this issue when merged 🤷

Can you close it @FlorianK13 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue This issue is suitable for a first time contribution 👐 help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature 489 requests identify as open mastr OpenEnergyPlatform/open-MaStR
2 participants
@maurerle @FlorianK13