-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tone Mapping parameter missing for mvs_texturing #492
Comments
I will see if exposing this parameter will help. |
https://github.com/dakotabenjamin/OpenDroneMap/tree/tone-mapping-param Note that this doesn't include an update to MVS-Texturing. You will have to pull #471 changes in or update manually. I don't have a dataset on hand to find any tangible differences between 'gamma' and 'none' so I'm hoping you can test that. Also, I was unsure whether to use the mvs-tex args (gamma and none) or just a boolean flag, but can easily switch if you think one is preferable over the other. |
Thank you @dakotabenjamin! I will do some testing and report my results. |
I'll close this since it has been taken care of as part of #499 |
While digging through mvs_texturing's code, I noticed that we currently don't have a way to enable the tone mapping feature, here:
https://github.com/nmoehrle/mvs-texturing/blob/master/apps/texrecon/arguments.cpp#L69
Which I think is directly related to the "bland" colors you sometimes observe as output on the orthophotos:
Notice the white areas near trees.
This seems directly related to the tone mapping feature, which is disabled by default: nmoehrle/mvs-texturing#24
The text was updated successfully, but these errors were encountered: