Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark.txt updated when step is passed #1650

Open
Adrien-LUDWIG opened this issue May 16, 2023 · 0 comments
Open

benchmark.txt updated when step is passed #1650

Adrien-LUDWIG opened this issue May 16, 2023 · 0 comments

Comments

@Adrien-LUDWIG
Copy link
Contributor

How did you install ODM? (Docker, installer, natively, ...)?

Docker

What is the problem?

The file benchmark.txt is updated even if the step was not actually computed but simply passed because the corresponding files were found.
As a consequence, if a project is treated in multiple executions (for example, it stoped for any reason in the middle and is resumed from there), the time of the steps of the first execution(s) won't be representative.

What should be the expected behavior? If this is a feature request, please describe in detail the changes you think should be made to the code, citing files and lines where changes should be made, if possible.

I would expect benchmark.txt not to be updated for a given step if the corresponding output was found instead of computed.

How can we reproduce this? What steps did you do to trigger the problem? If this is an issue with processing a dataset, YOU MUST include a copy of your dataset AND task output log, uploaded on Google Drive or Dropbox (otherwise we cannot reproduce this).

  • Launch a reconstruction project
  • Ctrl+C after some steps to mimic an unwanted crash
  • Resume the reconstruction project
  • Look at benchmark.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants