Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Return meshes from split merge #1594

Open
smathermather opened this issue Feb 2, 2023 · 2 comments
Open

Feature request: Return meshes from split merge #1594

smathermather opened this issue Feb 2, 2023 · 2 comments
Assignees

Comments

@smathermather
Copy link
Contributor

Per https://community.opendronemap.org/t/offer-a-single-textured-mesh-as-output-in-split-merge-processes/14608 , long term, returning a mesh from split merge would be beneficial. In the interim, returning the meshes that are produced may be an acceptable alternative.

Sibling issue here:
OpenDroneMap/NodeODM#199

@smathermather
Copy link
Contributor Author

@pierotofy -- the links you reference in the NodeODM issue, would that be something similar to how multispectral datasets are handled with symlinks or something as simple as what we see in stages/splitmerge.py with submodel paths for e.g. all_orthos_and_ortho_cuts?

@pierotofy
Copy link
Member

  • Scan the submodel folders for textured model files (similar to all_orthos_and_ortho_cuts)
  • Create the necessary folder structure via symlinks / hardlinks in the root odm_texturing folder. (e.g. odm_texturing/submodel_0000/odm_textured_model_geo.obj, ...)

Symlinks are not available on Windows (you need to use hardlinks, which only work for files, not directories). Using links is the proper way to implement this imo. Naive copies are both slow and explode disk space.

Starting from

def link_file(src, dst):
, extend it to support files and folders, recursively. ⚠️ it's not hard, but with anything FS related it's not super trivial either!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants