Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Better Banana (feature request) #1417

Open
ichsan2895 opened this issue Feb 12, 2022 · 5 comments
Open

For Better Banana (feature request) #1417

ichsan2895 opened this issue Feb 12, 2022 · 5 comments

Comments

@ichsan2895
Copy link

I have tested this Banana Dataset

These settings are
run --project-path “D:\qwerty\Banana_ODM” --mesh-octree-depth 14 --mesh-size 300000 --pc-quality ultra --pc-geometric

I got a banana with very sharp texture which is really great (IMO better than Reality Capture texture with same dataset)
PCq_Ultra-FeatureQ_Ultra-3rd

But unfortunatelly, I can't eat this banana since there big hole in it
PCq_Ultra-FeatureQ_Ultra-1st

Why the hole appears? My hypothesis, it was appear at texturing stage since ODM remove the faces which ODM can't associated/interpolated from input images texture.

I checked /code/odm_meshing/odm_mesh.ply and it doesn't any hole in it, but it was uncolored.
image

I also try to add --texturing-keep-unseen-faces, The hole was dissapear ! but, the hole was filled by pure white faces.
image

Now the suggestion is, The texturing stage can interpolate the color of that faces instead of removing the faces or instead of fill it by pure white faces

@ichsan2895
Copy link
Author

Lets try with meshlab

/code/odm_filterpoints/point_cloud.ply has colored point cloud
image

I use meshlab's screened poisson with Resolution depth is 11 and Adaptive Octree Depth is 8. The result is good enough, the color of the hole was filled by interpolated point cloud colors
image
But the texture is not sharp as ODM
image

My idea was to sharper the colored point cloud with ODM's texturing stage. I rename that mesh to odm_mesh.ply, then put that mesh to /code/odm_meshing

But I was failed. The faces become dissapear again and get the hole

Still figure it how to fix that.

@ichsan2895
Copy link
Author

BONUS :
Another photogrammetry software result

IMO, I have said the ODM texture was better than Reality Capture, here is the screenshot
RealityCapture-3rd

Keep good works !

But, Reality Capture tends to give color to the faces rather that removing it.

This is Reality capture with high quality settings for Reconstruction
image

@pierotofy
Copy link
Member

The key problem is that currently mvs-texturing does not support texture interpolation.

Would you be interested in adding support for it?

@ichsan2895
Copy link
Author

ichsan2895 commented Feb 18, 2022

The key problem is that currently mvs-texturing does not support texture interpolation.

Would you be interested in adding support for it?

Thanks for your information that mvs-texturing doesn't support texture interpolation. What can I do beside coding? Maybe I have plan to buy native windows WebODM for fund support

I also tried to increase this value which located in this file

#define MAX_HOLE_NUM_FACES 100
#define MAX_HOLE_PATCH_SIZE 100

But since I don't know coding, I confuse how to change that file which is inside Docker environment. I use MXLinux 19.4 and WebODM Docker version.

ANOTHER (NOT YET PROVEN) IDEA

/code/odm_filterpoints/point_cloud.ply is already colored point cloud.

But /code/odm_meshing/odm_mesh.ply is not colored yet

My suggestion, Poisson reconstruction with ODM should be colored, so the odm_mesh.ply has colored mesh and there are interpolated texture color on unseen faces which is extracted from point cloud.

Activate Mvs-texture --keep-unseen-texturing-faces, but give it transparent color instead of pure white faces. So, the previous interpolated texture will show to the unseen faces instead of remove that faces that caused hole.

@pierotofy
Copy link
Member

See https://opendronemap.org/get-involved/ for ways to help the project!

This is something tricky to add, since Reality Capture derives its point cloud from some type of mesh-like interpolation, it works quite differently from ODM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants