Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Additional Control Point Types #1302

Open
Saijin-Naib opened this issue Jun 11, 2021 · 3 comments
Open

Feature Request: Additional Control Point Types #1302

Saijin-Naib opened this issue Jun 11, 2021 · 3 comments

Comments

@Saijin-Naib
Copy link
Contributor

Saijin-Naib commented Jun 11, 2021

I think it would be very helpful to have a concept within ODM of multiple types of control points.

Currently, we have the concept of 3D Ground Control Points (XYZ). I think a more expanded list would look like this:

  1. Ground Control Point (XY)
    1A) For horizontal scaling/registration without high confidence in Z
  2. Scale Constraint (XY/XZ/YZ)
    2A) To scale the point cloud in a scene given pairs of points with a known distance
  3. Manual Tie Point (XY/XYZ)
    3A) Manually identified in-situ features
  4. Check Point (XY/XYZ)
    4A) Used only for Report/verification, not for adjusting reconstruction
@pierotofy
Copy link
Member

pierotofy commented Jul 11, 2022

  1. Might be a bug (nan should allow to not use elevation)

@Saijin-Naib
Copy link
Contributor Author

I'm not sure where along the line the NaN failure came about, but it is a thing we've seen a few times recently(ish):
https://community.opendronemap.org/search?expanded=true&q=GCP%20NaN%20order%3Alatest

@kikislater
Copy link
Member

For 2... Useful with dome/banana effect.
May be a workaround is possible:

  • Running complete process
  • Measure distance in potree
  • Divide measured distance in potree by real measurement
  • Add option in ODM to scale model
  • Re-run process from beginning using new scale option and use scale value in pdal command. Scale is available in some pdal's writers

Reference: mapillary/OpenSfM#737

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants