Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scanPosition endpoint #26

Open
alesgenova opened this issue Jun 5, 2019 · 1 comment
Open

scanPosition endpoint #26

alesgenova opened this issue Jun 5, 2019 · 1 comment

Comments

@alesgenova
Copy link
Member

It looks to me that the scanPosition endpoint returns the same information (although through a different implementation) as the frames endpoint.
Am I missing something? @psavery

@psavery
Copy link
Contributor

psavery commented Jun 5, 2019

Yeah that is right. Originally, the GET /stem_images/{id}/frames was designed to return all frames, and the GET /stem_images/{id}/frames/{scanPosition} was designed to return just one frame.

However, because we added limit and offset to GET /stem_images/{id}/frames, you can now get one frame by specifying a limit of 1. So maybe GET /stem_images/{id}/frames/{scanPosition} is no longer needed. What do you think, @cjh1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants