Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merging files must move existing files in S3 and rewrite path in x_opencti_files #6258

Open
richard-julien opened this issue Mar 3, 2024 · 2 comments · May be fixed by #6671
Open

Merging files must move existing files in S3 and rewrite path in x_opencti_files #6258

richard-julien opened this issue Mar 3, 2024 · 2 comments · May be fixed by #6671
Assignees
@aHenryJard
Labels
bug use for describing something not working as expected
Milestone
Bugs backlog

Comments

@richard-julien
Copy link
Member

Description

When entities are merged, x_opencti_files are accumulated directly in the target.
However as the x_opencti_files are stored in a path that contains the internal_id of the element, this merging doesnt do the right operations.
Merging process must be improved to:

  • Move the files in the S3/Minio to the target entity
  • Rewrite the x_opencti_files sources to comply to the new path

Hints

Metadata of the file in s3 can be discarded are no longer used.
@richard-julien richard-julien added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team labels Mar 3, 2024
@richard-julien richard-julien added this to the Release 6.1.0 milestone Mar 3, 2024
@jborozco jborozco added needs more info Intel needed about the use case and removed needs triage use to identify issue needing triage from Filigran Product team labels Mar 4, 2024
@jborozco
Copy link
Member

jborozco commented Mar 4, 2024

@richard-julien I could not reproduce by uploading a file in an entity and merging the entity with another one.

Could you detail the steps to reproduce and the expected output?

@SamuelHassine
Copy link
Member

Hello,

This bug is confirmed, clear the the file is not moved to the new entity.

@jborozco jborozco removed the needs more info Intel needed about the use case label Mar 11, 2024
@Jipegien Jipegien modified the milestones: Release 6.0.8, Release 6.0.9 Mar 20, 2024
@aHenryJard aHenryJard self-assigned this Mar 26, 2024
@SamuelHassine SamuelHassine modified the milestones: Release 6.0.9, Release 6.0.10, Release 6.1.0 Apr 3, 2024
@aHenryJard aHenryJard linked a pull request Apr 11, 2024 that will close this issue
[backend] Merged entity should also have all files of the merged entity and at the right path in S3 (#6258) #6671
Draft
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aHenryJard aHenryJard

Labels
bug use for describing something not working as expected
Projects
None yet
Milestone
Bugs backlog
5 participants
@richard-julien @SamuelHassine @aHenryJard @jborozco @Jipegien