Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for cibuildwheel config in pyproject.toml #77

Open
ConorMacBride opened this issue Sep 22, 2022 · 1 comment
Open

Better support for cibuildwheel config in pyproject.toml #77

ConorMacBride opened this issue Sep 22, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@ConorMacBride
Copy link
Member

Currently the two publish workflows create jobs which set CIBW_BUILD and CIBW_ARCHS environment variables depending on the list of targets specified as an input to this workflow. These environment variables override any cibuildwheel config for build or archs set in pyproject.toml. (It should at least be documented that the publish workflows do not support build or archs within pyproject.toml.)

A fix would be to update tools/load_build_targets.py to parse pyproject.toml for build and archs configuration, and merge/adjust/replace the targets specified as an input to this workflow with the pyproject.toml config. I think the simplest solution would be to support either build config in pyproject.toml OR the targets workflow input.

@ConorMacBride ConorMacBride added the enhancement New feature or request label Sep 22, 2022
@Cadair
Copy link
Member

Cadair commented Sep 23, 2022

Could we "just" make targets optional? Then we wouldn't have to parse pyproject and just let cibuildwheel handle it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants