Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python package caching #102

Closed
wants to merge 1 commit into from

Conversation

dstansby
Copy link
Contributor

@dstansby dstansby commented Jan 2, 2023

Fixes #62

@Cadair
Copy link
Member

Cadair commented Jan 2, 2023

Having had another look at the description on the setup-python action, I think we are going to need to tell it what files to use to control the cache?

Input cache-dependency-path is used for cases when multiple dependency files are used, they are located in different subdirectories or different files for the hash that want to be used.

Although i don't know what files sunpy would use to control the cache as it would need updating regularly to catch the newest files and we don't have a pins file?

@dstansby
Copy link
Contributor Author

dstansby commented Jan 2, 2023

Yeah, I wonder if it's easiest for users of this action to do this manually using the caching arguments already present? At least this PR isn't a general enough approach, so I'll close.

@dstansby dstansby closed this Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for pip dependency caching
2 participants