Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for using an environment for the upload step #37

Open
Cadair opened this issue Apr 6, 2022 · 3 comments
Open

Add support for using an environment for the upload step #37

Cadair opened this issue Apr 6, 2022 · 3 comments

Comments

@Cadair
Copy link
Member

Cadair commented Apr 6, 2022

It would be cool if you could specify what environment to use just for the upload step rather than the current situation where you have to specify it for the whole publish workflow.

This would allow someone to approve the upload after all the builds complete.

@ConorMacBride
Copy link
Member

Unless the job environment input has a default value, we would have to duplicate the upload job: one job if an environment input is passed to the workflow and another if it isn't. Is that adding too much complexity? Especially with the Anaconda.org upload step, this would be a lot of duplicated code.

Also, the upload step for publish_pure_python.yml does not have a separate job for upload. Move to a separate job or apply environment to whole workflow?

@Cadair
Copy link
Member Author

Cadair commented Apr 6, 2022

Does referencing an environment which doesn't exist work?!

Could we use a composite action to reduce the duplication?

@Cadair
Copy link
Member Author

Cadair commented Jan 26, 2024

Looking into this a bit more, it seems you can use environment: and with: in the same block, so we will have to add explicit support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants