Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow tox testing inside Docker #12

Open
ConorMacBride opened this issue Mar 7, 2022 · 2 comments
Open

Allow tox testing inside Docker #12

ConorMacBride opened this issue Mar 7, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@ConorMacBride
Copy link
Member

The OpenAstronomy Azure Pipelines tox template supports running tox inside docker containers. "This was originally added to support testing against 32bit linux builds using the manylinux official docker images, so there is specific support for these images."

There does not seem to be any public repos on GitHub using the manylinux option or any of the docker_ options. However, only astrofrog/fast-histogram and astropy/astropy-healpix are using the linux32 option.

@ConorMacBride ConorMacBride added the enhancement New feature or request label Mar 7, 2022
@astrofrog
Copy link
Contributor

I wonder if it's sufficient to use the publish workflow for this since this does give us 32-bit builds/tests with minimal hassle. We could always document that as a way to do 32-bit builds.

@ConorMacBride
Copy link
Member Author

For most use cases I think that would be sufficient. There won't be any coverage testing and the tox.ini and pytest configuration in setup.cfg won't be used, but unless a package is doing something special for 32 bit, a simple call to pytest should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants